Extract "ModelEvaluation" component#3432
Merged
shati-patel merged 2 commits intomainfrom Feb 29, 2024
Merged
Conversation
shati-patel
force-pushed
the
shati-patel/componentize
branch
from
5b4f5ff to
90cc656
Compare
Also extract "ProgressRing" (to avoid circular dependency)
shati-patel
force-pushed
the
shati-patel/componentize
branch
from
90cc656 to
e6b2835
Compare
charisk
approved these changes
Feb 29, 2024
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Thanks. I wasn't sure about the name but I think it's okay because it's scoped within the model-editor area.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No user-visible changes. This PR slightly refactors the ModelEditor component into smaller components, so that we can more easily make changes later!
Checklist
N/A
ready-for-doc-reviewlabel there.