Merged
Conversation
koesie10
force-pushed
the
koesie10/extension-managed-location
branch
from
3e6bddc to
f426178
Compare
3 tasks
robertbrignull
approved these changes
Mar 11, 2024
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
The code change look ok and I assume you've tested it locally that it fixes the bug and works ok. So I'm happy to approve on those grounds.
I'm surprised there are no test changes. Are there no tests of deleting databases?
| extensionManagedLocation?: string; | ||
| } | ||
|
|
||
| export interface FullDatabaseOptions extends DatabaseOptions { |
Contributor
There was a problem hiding this comment.
Don't worry it's not anything to do with this PR, but I don't think I've seen this code before and I don't love that it's a new piece of persisted data mixed with internal types...
Member
Author
Thanks for noticing that. There do seem to be some tests for deleting databases, so I'll add a new one that tests the extension managed location. |
robertbrignull
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When downloading a database from GitHub, the folder structure looks like this within the
${context.storageUri}/cppdirectory:When removing this database, we were only deleting the shown
cppdirectory, and not the top-levelcppdirectory because we were deleting the directory that contained the database, rather than the directory that was created during the download.This fixes it by storing the directory that we create during download on the database item so we can remove that directory when removing the database.
Checklist
ready-for-doc-reviewlabel there.