Use VSCodeBadge instead of custom styled component#3462
Merged
shati-patel merged 1 commit intomainfrom Mar 13, 2024
Merged
Conversation
shati-patel
commented
Mar 12, 2024
Comment on lines
+36
to
+37
| role="button" | ||
| aria-label="Model alerts" |
Contributor
Author
There was a problem hiding this comment.
Added this to make the tests pass and to make the button accessible 🤔 Not sure if this is the "normal" way of doing things? 🤷🏽
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes a few buttons in the model editor to use the
VSCodeBadgecomponent from the webview UI toolkit. Follow-up from #3441 (comment).Before:
After:
Checklist
N/A: the usages button has just changed a tiny amount, and the model alerts button is feature-flagged
ready-for-doc-reviewlabel there.