Skip to content

Move LinkIconButton to common dir#3467

Merged
charisk merged 1 commit intomainfrom
charisk/move-link-icon-button
Mar 14, 2024
Merged

Move LinkIconButton to common dir#3467
charisk merged 1 commit intomainfrom
charisk/move-link-icon-button

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Mar 14, 2024

The LinkIconButton component is already used in other places, not just for variant analysis so I've moved it to a common dir.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested review from a team as code owners March 14, 2024 09:25
norascheuch
norascheuch approved these changes Mar 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@charisk charisk enabled auto-merge (squash) March 14, 2024 09:28
@charisk charisk merged commit bbc881e into main Mar 14, 2024
@charisk charisk deleted the charisk/move-link-icon-button branch March 14, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koesie10 koesie10 koesie10 approved these changes

@norascheuch norascheuch norascheuch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charisk @koesie10 @norascheuch