Skip to content

Add model packs to variant analyses#3472

Merged
charisk merged 1 commit intomainfrom
charisk/variant-analysis-model-packs
Mar 14, 2024
Merged

Add model packs to variant analyses#3472
charisk merged 1 commit intomainfrom
charisk/variant-analysis-model-packs

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Mar 14, 2024

Adds modelPacks to variant analysis entities and flows that through from when the packs are discovered to when the entity is created.

The modelPacks property is not persisted yet so it's not mapped over when transforming to query history items. This is intentional - we will change that once we're more confident with the shape of the data. See internal linked issue for details.

Note that this is not used yet, it will be wired up in a follow up PR.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner March 14, 2024 13:04
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🖖🏽

@charisk charisk merged commit 115ff83 into main Mar 14, 2024
@charisk charisk deleted the charisk/variant-analysis-model-packs branch March 14, 2024 14:39
@charisk
Copy link
Copy Markdown
Contributor Author

charisk commented Mar 14, 2024

Oops, I got a bit too happy and pressed the merge button, potentially without giving enough people a chance to review. @robertbrignull (and anyone else) please let me know if you have any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants