Add model alerts stats to the view #3481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shati-patel
force-pushed
the
shati-patel/model-alerts-stats
branch
from
f8ae2aa to
25d0335
Compare
shati-patel
commented
Mar 18, 2024
Comment on lines
3
to
9
| import { ModelAlerts as ModelAlertsComponent } from "../../view/model-alerts/ModelAlerts"; | ||
|
|
||
| export default { | ||
| title: "CodeQL Model Alerts/CodeQL Model Alerts", | ||
| title: "Model Alerts/Model Alerts", | ||
| component: ModelAlertsComponent, | ||
| } as Meta<typeof ModelAlertsComponent>; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I can't get anything to appear in the main "model alerts" story (only in the new "model alerts header" story) 🤔
I could delete it, but I'm probably just doing something stupid to prevent things from working 😅
Contributor
There was a problem hiding this comment.
We (me) probably broke the story - you shouldn't need to do anything to get it working. I can take a look.
shati-patel
commented
Mar 18, 2024
| case "openLogs": | ||
| await this.app.commands.execute( | ||
| "codeQL.openVariantAnalysisLogs", | ||
| 123, // TODO: Get the actual variantAnalysisId |
Contributor
Author
There was a problem hiding this comment.
I couldn't figure out how to get the variant analysis (ID) at this point 🤔
Contributor
There was a problem hiding this comment.
You can get send the id in the message from the view.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a stats row to the model alerts view
Checklist
N/A
ready-for-doc-reviewlabel there.