Wire up variant analysis updates to Model Alerts view#3485
Merged
Conversation
shati-patel
approved these changes
Mar 18, 2024
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Looks good, thanks! ✨
| await this.updateView({ | ||
| if (variantAnalysis.id === variantAnalysisId) { | ||
| // Update model editor view | ||
| await this.updateModelEditorView({ |
Contributor
There was a problem hiding this comment.
Thanks for updating these names and making things clearer ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates model evaluation to listen to updates to pieces of state that relate to variant analyses (variant analysis, repo states, repo results) and propagate those updates to the Model Alerts view.
To achieve this, I've updated the
VariantAnalysisManagerto publish events for changes to the repo states and repo results (it was already publishing events for variant analyses updates).The view doesn't use the repo states and repo results properly yet - it just prints stuff out as JSON.
Checklist
N/A:
ready-for-doc-reviewlabel there.