Three minor improvements to testproj import
#3486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking to re-import test databases, if the target database is missing or otherwise unavailable, avoid the check and just continue. This avoids a bug where a user would delete a test database and there would be an error when trying to run a query.
Use the testproj style import when using the folder icon to import a database. This means that if the database directory ends with `testproj` copy the database into workspace storage and make it available for re-importing when the origin database changes.
Contributor
Author
|
@koesie10 would you be able to review this? |
aeisenberg
changed the title
testproj importtestproj import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing from a directory, check for testproj
Use the testproj style import when using the folder icon to import a
database. This means that if the database directory ends with
testprojcopy the database into workspace storage and make it available for
re-importing when the origin database changes.
Safely check for out of date databases
When checking to re-import test databases, if the target database is
missing or otherwise unavailable, avoid the check and just continue.
This avoids a bug where a user would delete a test database and there
would be an error when trying to run a query.
Ensure database sources are zipped on re-import
(Commit-by-commit review is recommended).
Checklist
ready-for-doc-reviewlabel there.