Skip to content

Move AnalysisAlert mock creation to a factory module#3493

Merged
charisk merged 1 commit intomainfrom
charisk/analysis-alert-factories
Mar 20, 2024
Merged

Move AnalysisAlert mock creation to a factory module#3493
charisk merged 1 commit intomainfrom
charisk/analysis-alert-factories

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Mar 20, 2024

This is so it can be re-used in other stories/tests.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner March 20, 2024 10:29
@charisk charisk force-pushed the charisk/analysis-alert-factories branch from 7f6dbdc to 6618676 Compare March 20, 2024 10:50
shati-patel
shati-patel approved these changes Mar 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🏭

@charisk charisk merged commit 6c3b0b5 into main Mar 20, 2024
@charisk charisk deleted the charisk/analysis-alert-factories branch March 20, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charisk @shati-patel