Wire up processing model evaluation run results and showing alerts#3503
Wire up processing model evaluation run results and showing alerts#3503
Conversation
cb44355 to
dcc34a8
Compare
dcc34a8 to
fd808c8
Compare
| | SetRepoResultsMessage | ||
| | SetReposResultsMessage; |
There was a problem hiding this comment.
I think the difference between the SetRepoResultsMessage and SetReposResultsMessage is not clear from the name. The data seems to be exactly the same, so it's quite confusing (at least to me) when we have both messages and they have different functions. Perhaps a name like ReplaceRepoResultsMessage would be better (based on its function in the view code)? The same might be useful for the functions on the model alerts view, something like updateRepoResult and replaceRepoResults?
There was a problem hiding this comment.
Agree it's quite confusing. I think that setReposResultsMessage is the correct name for what I'm adding, but that the other messages (and related view functions) should be "addRepoResults" or something like that. Essentially set should be used when we're actually setting the whole thing, otherwise we should use some other term.
I was hoping to tidy this up in a future PR, what do you think?
There was a problem hiding this comment.
That makes sense to me, I don't think this needs to be blocking for this PR.
Wires up the model evaluator to trigger loading of variant analysis repository results, process them and update the model alerts view.
In the absence of alert provenance information, we fake process the analysis results for now, and return mock results.
Checklist
N/A:
ready-for-doc-reviewlabel there.