Update model alert processing to track repo results#3508
Merged
Conversation
shati-patel
approved these changes
Mar 25, 2024
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Seems reasonable to me! Especially without knowing the exact shape of the data yet 🔮
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to implement some of the filtering we want in the
ModelAlertsview, we need to keep track of which repo an alert has come from. This PR updates theModelAlertsentity to hold repository information and thealerts-processorto propagate it.I'm not convinced about the shape of the
ModelAlertsentity yet - I think things will be clearer once we have alert provenance information.Checklist
N/A:
ready-for-doc-reviewlabel there.