Use wider type for "reveal in model editor"#3512
Merged
shati-patel merged 1 commit intomainfrom Mar 26, 2024
Merged
Conversation
charisk
approved these changes
Mar 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The model alerts view will have a button that lets you open the method in the model editor (to be added in a follow-up PR):
I want to re-use the existing "reveal in model editor" event (used by the method modeling side bar), but that uses the
Methodtype (instead ofModeledMethod, like in the model alerts view).Both of those extend the
MethodSignaturetype, so I think it makes sense to use that as a suitable "wider" type to accommodate both. I've tested that the button in the method modeling side bar still works as normal 🧪 🎉Checklist
N/A, no user visible impact
ready-for-doc-reviewlabel there.