Skip to content

Use wider type for "reveal in model editor"#3512

Merged
shati-patel merged 1 commit intomainfrom
shati-patel/view-alert-in-editor
Mar 26, 2024
Merged

Use wider type for "reveal in model editor"#3512
shati-patel merged 1 commit intomainfrom
shati-patel/view-alert-in-editor

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel commented Mar 26, 2024

The model alerts view will have a button that lets you open the method in the model editor (to be added in a follow-up PR):

image

I want to re-use the existing "reveal in model editor" event (used by the method modeling side bar), but that uses the Method type (instead of ModeledMethod, like in the model alerts view).

Both of those extend the MethodSignature type, so I think it makes sense to use that as a suitable "wider" type to accommodate both. I've tested that the button in the method modeling side bar still works as normal 🧪 🎉

Checklist

N/A, no user visible impact

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel marked this pull request as ready for review March 26, 2024 12:35
@shati-patel shati-patel requested review from a team as code owners March 26, 2024 12:35
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shati-patel shati-patel merged commit ccd5313 into main Mar 26, 2024
@shati-patel shati-patel deleted the shati-patel/view-alert-in-editor branch March 26, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants