Skip to content

Fix click propagation for "View" link in model alerts view#3519

Merged
shati-patel merged 1 commit intomainfrom
shati-patel/click-propagation
Mar 27, 2024
Merged

Fix click propagation for "View" link in model alerts view#3519
shati-patel merged 1 commit intomainfrom
shati-patel/click-propagation

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel commented Mar 27, 2024

Minor follow-up to #3514. Clicking the "View" link shouldn't also expand/collapse the row 🙃

image

Checklist

N/A: still feature-flagged

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel requested a review from a team as a code owner March 27, 2024 11:16
charisk
charisk approved these changes Mar 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch!

@shati-patel shati-patel merged commit 317d3b3 into main Mar 27, 2024
@shati-patel shati-patel deleted the shati-patel/click-propagation branch March 27, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charisk charisk charisk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shati-patel @charisk