Add helper for substituting config variables#3530
Conversation
ccf5450 to
8cb2b34
Compare
robertbrignull
left a comment
There was a problem hiding this comment.
Implementation LGTM. Thanks for including the link to the vscode repo.
Side question: as well as the new model packs uses, do you plan to replace the interpolation in HistoryItemLabelProvider with this implementation?
I don't think we can without breaking existing settings since that uses a format like |
Might be worth an issue to track this as potential tech/product debt. |
This adds a helper for substituting config variables, such as the following:
.github/codeql/extensions/${name}-${language}becomes.github/codeql/extensions/vscode-codeql-java${owner}/${name}-${language}becomesgithub/vscode-codeql-java${workspaceFolder}${pathSeparator}.github/workflows/codeql-analysis.ymlbecomes/home/your-username/your-project/.github/workflows/codeql-analysis.ymlThis is based on the implementation in VS Code that is used for the
window.titlesetting. Some of the unit tests are also based on the VS Code unit tests.This helper function will be used in follow-up PRs that introduce new settings for model packs.
Checklist
ready-for-doc-reviewlabel there.