Update README with new command for adding database#376
Merged
jcreedcmu merged 1 commit intogithub:masterfrom May 19, 2020
Merged
Update README with new command for adding database#376jcreedcmu merged 1 commit intogithub:masterfrom
jcreedcmu merged 1 commit intogithub:masterfrom
Conversation
jcreedcmu
approved these changes
May 19, 2020
Contributor
jcreedcmu
left a comment
jcreedcmu
left a comment
There was a problem hiding this comment.
This is great, thanks! I agree that the downloaded-zip-from-LGTM is probably the commonest/easiest way to get a database for people getting started, and seems appropriate to recommend here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.1.5 release (specifically #366) removed the "+" icon for adding databases. I've updated the README to point people to a new command.
Note: Though there are multiple ways to add databases, I think it makes sense to keep the "Quick start" guide in the README as simple as possible. We'll go into more detail in the documentation.
cc @aeisenberg or @jcreedcmu for review, thanks!
Checklist
N/A: We have an internal docs issue to track changes to the database commands
@github/product-docs-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.