Skip to content

Conversation

@asgerf
Copy link
Contributor

@asgerf asgerf commented Nov 14, 2024

  • Styles the RA, highlighting the last part of an identifier and keywords
  • Makes abbreviations ("...") clickable to show the whole abbreviation
  • Also abbreviates predicates in the top-level table, not just in RA steps
  • Applies a gray background to table headers. Helps distinguish the different uses of bold.

Commit by commit review recommended as a file was renamed from .ts to .tsx which messes up the combined diff.

@asgerf asgerf requested a review from a team as a code owner November 14, 2024 10:51
@asgerf asgerf requested review from esbena and tausbn November 14, 2024 10:51
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't scrutinise the RA pretty-printing that much (I figure if it looks good, that's good enough), but the rest looks good to me. 👍

@asgerf asgerf merged commit 005e651 into github:hackathon/compare-perf Nov 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants