Skip to content

Compare-perf: Also parse COMPUTE_SIMPLE events #3810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Compare-perf: Also parse COMPUTE_SIMPLE events #3810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extensions/ql-vscode/src/log-insights/log-summary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ interface ResultEventBase extends SummaryEventBase {
export interface ComputeSimple extends ResultEventBase {
evaluationStrategy: "COMPUTE_SIMPLE";
ra: Ra;
millis: number;
pipelineRuns?: [PipelineRun];
queryCausingWork?: string;
dependencies: { [key: string]: string };
Expand Down
10 changes: 7 additions & 3 deletions extensions/ql-vscode/src/log-insights/performance-comparison.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ export class PerformanceOverviewScanner implements EvaluationLogScanner {
switch (event.evaluationStrategy) {
case "EXTENSIONAL":
case "COMPUTED_EXTENSIONAL":
case "COMPUTE_SIMPLE":
case "CACHACA": {
// TODO: is CACHACA effectively the same as cache hit?
break;
Expand All @@ -122,12 +121,17 @@ export class PerformanceOverviewScanner implements EvaluationLogScanner {
break;
}
case "COMPUTE_RECURSIVE":
case "COMPUTE_SIMPLE":
case "IN_LAYER": {
const index = this.getPredicateIndex(event.predicateName);
let totalTime = 0;
let totalTuples = 0;
for (const millis of event.predicateIterationMillis ?? []) {
totalTime += millis;
if (event.evaluationStrategy === "COMPUTE_SIMPLE") {
totalTime += event.millis;
} else {
for (const millis of event.predicateIterationMillis ?? []) {
totalTime += millis;
}
}
const {
timeCosts,
Expand Down
Loading