Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the typescript-plugin-css-modules dependency and its configuration to eliminate a transitive dependency on the problematic stylus package, which has been wiped from npm and is no longer available.
- Removes the TypeScript plugin configuration from the tsconfig.json file
- Removes the
typescript-plugin-css-modulespackage dependency from package.json
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extensions/ql-vscode/src/view/tsconfig.json | Removes the TypeScript plugin configuration for css-modules |
| extensions/ql-vscode/package.json | Removes the typescript-plugin-css-modules dependency |
Files not reviewed (1)
- extensions/ql-vscode/package-lock.json: Language not supported
Contributor
Author
|
Looks like we won't need this. The flagging of stylus might have been an error and will be rolled back, or if we do still need to work around stylus then we'll use a npm package override instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
typescript-plugin-css-modules, with the end goal of removing our transitive dependency onstylus. Unfortunately thestyluspackage was found to contain malicious code so it has been wiped and version0.62.0that we depended on no longer exists.As far as I can tell, the
typescript-plugin-css-modulespackage was only giving us extra type information in the IDE and doesn't contribute to actual compilation or error checking at compile time. So maybe we can just do without this until we find a replacement.