Skip to content

Update the download from LGTM section in the readme#411

Merged
jcreedcmu merged 8 commits intogithub:masterfrom
aeisenberg:aeisenberg/readme-lgtm
May 29, 2020
Merged

Update the download from LGTM section in the readme#411
jcreedcmu merged 8 commits intogithub:masterfrom
aeisenberg:aeisenberg/readme-lgtm

Conversation

@aeisenberg
Copy link
Copy Markdown
Contributor

Updates the readme to take into account #405.

Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the instructions @aeisenberg (and for tidying up some lists/spacing)! I've added a few more suggestions for formatting/style, but this looks great overall.

The new download option will make things even easier for people to get hold of their first database 🎉

Comment thread extensions/ql-vscode/README.md Outdated
Comment thread extensions/ql-vscode/README.md Outdated
Comment thread extensions/ql-vscode/README.md Outdated
Comment thread extensions/ql-vscode/README.md Outdated
Comment thread extensions/ql-vscode/README.md Outdated
Comment thread extensions/ql-vscode/README.md Outdated
Comment thread extensions/ql-vscode/README.md Outdated
aeisenberg and others added 7 commits May 29, 2020 08:17
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
@aeisenberg
Copy link
Copy Markdown
Contributor Author

Thanks for the cleanups, @shati-patel. They're all committed. Could I get another review here so I can merge?

Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😊

@jcreedcmu jcreedcmu merged commit 7b5f749 into github:master May 29, 2020
@aeisenberg aeisenberg deleted the aeisenberg/readme-lgtm branch May 29, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants