Use semver package for semantic version comparison and precedence checking#427
Merged
henrymercer merged 7 commits intogithub:masterfrom Jun 2, 2020
henrymercer:fix-semver-comparison
Merged
Use semver package for semantic version comparison and precedence checking#427henrymercer merged 7 commits intogithub:masterfrom henrymercer:fix-semver-comparison
henrymercer merged 7 commits intogithub:masterfrom
henrymercer:fix-semver-comparison
Conversation
Suppose a user has the includePrereleases config option set, installs an extension-managed prerelease, then decides they no longer want prereleases and disables includePrereleases. In this case, we should prompt the user to downgrade the CLI to a non-prerelease version. However, if the user is managing their own CLI, we will allow them to use prereleases without incompatibility prompts.
aeisenberg
previously approved these changes
Jun 2, 2020
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Looks good to me. Just a couple of stylistic and wording suggestions that you can take or leave.
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
Contributor
Author
|
Thanks @aeisenberg, I agree with and have applied your suggestions. |
jcreedcmu
previously approved these changes
Jun 2, 2020
adityasharad
reviewed
Jun 2, 2020
Contributor
adityasharad
left a comment
adityasharad
left a comment
There was a problem hiding this comment.
Looks good overall! Some suggestions for clarity (not blocking) and test coverage.
adityasharad
approved these changes
Jun 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the CLI distribution manager to use the semver package. This:
Other points to note:
semver.parserather thansemver.coercesincesemver.coercestrips build metadata.version.rawsince this includes build metadata.en-USlocale to remove potential locale dependence of version comparison.Checklist
@github/product-docs-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.Fixes #424