Skip to content

Clarify log message#430

Merged
aeisenberg merged 2 commits intogithub:masterfrom
aeisenberg:aeisenberg/open-log-message
Jun 5, 2020
Merged

Clarify log message#430
aeisenberg merged 2 commits intogithub:masterfrom
aeisenberg:aeisenberg/open-log-message

Conversation

@aeisenberg
Copy link
Copy Markdown
Contributor

This should cause less confusion and annoyance from users.

Copy link
Copy Markdown
Contributor

@jcreedcmu jcreedcmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improving this message makes sense, but isn't this dialog still presenting a
Yes/No question as to whether the extension should open the file
externally? I would expect maybe we want something like:

VS Code does not allow extensions to open files >50MB. This file
exceeds that limit. Do you want to open it outside of VS Code?

You can also try manually opening it inside VS Code by selecting
the file in the file explorer and dragging it into the workspace.

@jcreedcmu jcreedcmu requested a review from MathiasVP June 5, 2020 16:08
@aeisenberg
Copy link
Copy Markdown
Contributor Author

That sounds better.

Copy link
Copy Markdown
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely like this message better! Thanks for clarifying it.

@aeisenberg aeisenberg merged commit 46e7382 into github:master Jun 5, 2020
@aeisenberg aeisenberg deleted the aeisenberg/open-log-message branch November 24, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants