Merged
Conversation
jcreedcmu
suggested changes
Jun 5, 2020
Contributor
jcreedcmu
left a comment
There was a problem hiding this comment.
Improving this message makes sense, but isn't this dialog still presenting a
Yes/No question as to whether the extension should open the file
externally? I would expect maybe we want something like:
VS Code does not allow extensions to open files >50MB. This file
exceeds that limit. Do you want to open it outside of VS Code?
You can also try manually opening it inside VS Code by selecting
the file in the file explorer and dragging it into the workspace.
Contributor
Author
|
That sounds better. |
jcreedcmu
approved these changes
Jun 5, 2020
MathiasVP
approved these changes
Jun 5, 2020
Contributor
MathiasVP
left a comment
There was a problem hiding this comment.
I definitely like this message better! Thanks for clarifying it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should cause less confusion and annoyance from users.