Replace deprecated FormEvent with InputEvent#4395
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the SuggestBox webview component to avoid using React’s deprecated FormEvent type by switching the input handler to InputEvent, aligning with newer @types/react typings and helping keep the view codebase warning-free.
Changes:
- Replace
FormEvent<HTMLInputElement>withInputEvent<HTMLInputElement>for theonInputhandler. - Update the corresponding React type-only import.
Show a summary per file
| File | Description |
|---|---|
| extensions/ql-vscode/src/view/common/SuggestBox/SuggestBox.tsx | Switches SuggestBox’s input event typing away from deprecated FormEvent. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
cklin
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FormEventis deprecated:https://github.com/DefinitelyTyped/DefinitelyTyped/blob/ca06abb4cc3399ea070c122be329a22f1c3b6800/types/react/index.d.ts#L2078-L2082
For manual testing, I couldn't see how to trigger the
SuggestBoxin the extension UI, but it works just fine in the Storybook (and I temporarily added analert(...)to confirm the handler was being called with the right input.)I believe this will also fix the failures in #4383