Change references to master branch to main branch#452
Merged
jcreedcmu merged 1 commit intogithub:masterfrom Jun 17, 2020
Merged
Change references to master branch to main branch#452jcreedcmu merged 1 commit intogithub:masterfrom
jcreedcmu merged 1 commit intogithub:masterfrom
Conversation
I have already pushed `main` upstream pointing at the same commit as master, so this PR should be safe to merge. To the best of my knowledge all that's necessary after that is to change the default branch in https://github.com/github/vscode-codeql/settings/branches.
Contributor
Author
|
Fixes #453. |
Contributor
Author
|
@shati-patel anywhere else in docs we refer to specific urls starting from https://github.com/github/vscode-codeql/blob/master/ ? If so, could change them to https://github.com/github/vscode-codeql/blob/main/ . No great harm will come from not changing them yet --- not planning to delete the master branch yet, just deprecate. |
adityasharad
approved these changes
Jun 16, 2020
aeisenberg
approved these changes
Jun 16, 2020
Contributor
|
Note that we are also going to need to change the settings and add |
Contributor
Author
|
Yes, that's what I meant with the link in the PR description |
shati-patel
approved these changes
Jun 16, 2020
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Thanks for the ping! We have an issue to update the documentation 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have already pushed
mainupstream pointing at the same commit asmaster, so this PR should be safe to merge. To the best of my
knowledge all that's necessary after that is to change the
default branch
in https://github.com/github/vscode-codeql/settings/branches.