Augments the pagination styling#485
Merged
aeisenberg merged 2 commits intogithub:mainfrom Jul 6, 2020
Merged
Conversation
jcreedcmu
previously approved these changes
Jul 6, 2020
aeisenberg
force-pushed
the
aeisenberg/pagination-styling
branch
from
5e0d3cf to
e65a530
Compare
aeisenberg
force-pushed
the
aeisenberg/pagination-styling
branch
from
e65a530 to
c20eac1
Compare
jcreedcmu
approved these changes
Jul 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small changes that add consistency and modernizes the layout of the pagination section.
Should be based off of
jcreed:jcreed/interpreted-pagination#481. This is light theme:And this is dark:
I'm sure we could do better if we had an actual designer look at this, but this is probably good for now.
This is a follow-up review for #481.
Checklist
@github/product-docs-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.