Make error messages clearer for some common problems #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
force-pushed
the
aeisenberg/message-cleanup
branch
from
4cf7f0b to
69a4cac
Compare
adityasharad
reviewed
Dec 9, 2020
| } | ||
|
|
||
| if (!finalSingleItem) { | ||
| throw new Error('No query selected. Select a query history item you have already run and try again.'); |
Contributor
There was a problem hiding this comment.
Factor out to constant
| const yesItem = { title: 'Yes', isCloseAffordance: false }; | ||
| const alwaysItem = { title: 'Always Save', isCloseAffordance: false }; | ||
| const noItem = { title: 'No (run anyway)', isCloseAffordance: false }; | ||
| const noItem = { title: 'No (run version on disk)', isCloseAffordance: false }; |
Contributor
There was a problem hiding this comment.
Does 'the last saved version on disk' make sense?
Contributor
Author
There was a problem hiding this comment.
When would it ever not be the last saved version (unless you have a funky filesystem that automatically saves backup versions)?
Contributor
There was a problem hiding this comment.
I expect never: what you've written is correct, I'm just wondering whether we can make the message even more obvious.
1. Clicking on query history menu items when nothing is selected. Error message is clearer. It would be better to disable when nothing is selected, but waiting on microsoft/vscode#99767 to be released. 2. Trying to run query with a missing or invalid qlpack has better message. 3. Better hover text for "Open query". Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
aeisenberg
force-pushed
the
aeisenberg/message-cleanup
branch
from
f123a7f to
acb091f
Compare
adityasharad
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
message is clearer. It would be better to disable when nothing is
selected, but waiting on
Enablement using listDoubleSelection and listMultiSelection not working in contributed view microsoft/vscode#99767 to be released.
message.
Checklist
@github/docs-content-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.