Empty #750
Closed
Empty #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
force-pushed
the
aeisenberg/do-not-merge
branch
from
ae9d464 to
6966db0
Compare
Contributor
|
Make this draft? Then you won't create notifications. |
These functions assist with object disposal. They add custom behaviour during disposal. The primary usage of disposalHandlers is during testing where some objects should not be disposed in order to avoid testing errors.
aeisenberg
force-pushed
the
aeisenberg/do-not-merge
branch
from
791e164 to
ae748f2
Compare
aeisenberg
force-pushed
the
aeisenberg/do-not-merge
branch
from
896b34e to
fa4d031
Compare
don't run any no-workspace tests. Let's see if this helps.
aeisenberg
force-pushed
the
aeisenberg/do-not-merge
branch
from
fa4d031 to
61cb781
Compare
aeisenberg
added a commit
to aeisenberg/vscode-codeql
that referenced
this pull request
Feb 11, 2021
We should not be opening any external links during tests. This is causing some builds to hang when running on CI. See github#750 for an example.
aeisenberg
added a commit
to aeisenberg/vscode-codeql
that referenced
this pull request
Feb 11, 2021
We should not be opening any external links during tests. This is causing some builds to hang when running on CI. See github#750 for an example.
aeisenberg
added a commit
that referenced
this pull request
Feb 11, 2021
We should not be opening any external links during tests. This is causing some builds to hang when running on CI. See #750 for an example.
aofaof0907
pushed a commit
to aofaof0907/vscode-codeql
that referenced
this pull request
Jul 27, 2021
We should not be opening any external links during tests. This is causing some builds to hang when running on CI. See github#750 for an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not commit