Implement sorting of query history by name, date, and result count #777
Conversation
| } | ||
| ); | ||
| const resultSet = transformBqrsResultSet(schema, chunk); | ||
| results.setResultCount(resultSet.schema.rows); |
There was a problem hiding this comment.
This is a little confusing. The alerts table has 33 results in this example, but the #select table has 3906 results. I think people would expect that the result count matches the number of rows in the default table (in this case, it's alerts).
I'm not entirely sure why there is a difference here. I'm just running the example query from the starter repo:
/**
* @name Empty block
* @kind problem
* @problem.severity warning
* @id javascript/example/empty-block
*/
import javascript
from BlockStmt b
where b.getNumStmt() = 0
select b, "This is an empty block."It would be nice if we could get the counts for the default table, but I'm not sure how easy this is without loading the sarif.
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Looks good. And is working for me.
|
Can you squash and rebase your commits? |
edoardopirovano
force-pushed
the
history-sorting
branch
from
bca5000 to
bda80c2
Compare
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Sorry....a few more changes. Just noticed them. If a query has an error, the result count is -1. That should not be displayed in the UI.
Looks like -1 is being set in the code. Can you change this to 0?
edoardopirovano
force-pushed
the
history-sorting
branch
from
3e3a405 to
719d5c9
Compare
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround.
2 participants
This pull request addresses #767 by introducing three ways of sorting the query history view - by a query's label, by the date the query was run, and by the number of results the query produced.