Remove token for running a remote query#952
Merged
shati-patel merged 1 commit intomainfrom Sep 9, 2021
Merged
Conversation
robertbrignull
approved these changes
Sep 9, 2021
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
Not a VSCode reviewer, but from the point of view of the feature and the removal of the token from the API request this LGTM
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[internal feature]
The API for remote querying has changed (see linked issue), so we no longer need to provide a token in the Octokit request 🙂 This is a partial revert of this commit.
Checklist
N/A, no user-facing changes
@github/docs-content-codeqlhas been cc'd in all issues for UI or other user-facing changes made by this pull request.