Skip to content

fix: show logs for repos with non-lowercase owner name. Closes #15 #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lrotschy merged 2 commits into from
Apr 13, 2023
Merged

fix: show logs for repos with non-lowercase owner name. Closes #15 #115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45b3bea
fix: show logs for repos with non-lowercase owner name. Closes #15
danmana Apr 13, 2023
76c5e96
chore: use a map for performance when searching repos by owner and name
danmana Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/git/repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ export interface GitHubRepoContext {
export interface GitHubContext {
repos: GitHubRepoContext[];
reposByUri: Map<string, GitHubRepoContext>;
reposByOwnerAndName: Map<string, GitHubRepoContext>;
username: string;
}

Expand Down Expand Up @@ -199,6 +200,7 @@ export async function getGitHubContext(): Promise<GitHubContext | undefined> {
gitHubContext = Promise.resolve({
repos,
reposByUri: new Map(repos.map(r => [r.workspaceUri.toString(), r])),
reposByOwnerAndName: new Map(repos.map(r => [`${r.owner}/${r.name}`.toLocaleLowerCase(), r])),
username
});
} catch (e) {
Expand All @@ -224,7 +226,8 @@ export async function getGitHubContextForRepo(owner: string, name: string): Prom
return undefined;
}

return gitHubContext.repos.find(r => r.owner === owner && r.name === name);
const searchKey = `${owner}/${name}`.toLocaleLowerCase();
return gitHubContext.reposByOwnerAndName.get(searchKey);
}

export async function getGitHubContextForWorkspaceUri(
Expand Down