Skip to content

Add a globe icon to workflow steps that links to the GitHub.com specific step#170

Merged
KetchupOnMyKetchup merged 4 commits intomainfrom
ketchup-lrotschy/show-step-logs
May 3, 2023
Merged

Add a globe icon to workflow steps that links to the GitHub.com specific step#170
KetchupOnMyKetchup merged 4 commits intomainfrom
ketchup-lrotschy/show-step-logs

Conversation

@KetchupOnMyKetchup
Copy link
Copy Markdown
Contributor

@KetchupOnMyKetchup KetchupOnMyKetchup commented May 2, 2023

Closes #139

Issue:

  • Users with hundreds of steps would like an easier way to get to the steps.
  • User request "I wish the tree nodes for individual steps had a View logs icon just like the nodes for jobs.
  • Users want some action to happen when they click on steps.
  • We used to have a way to jump to the place in the steps but that was problematic and removed - b2380f0. We wanted to try to show just the step logs specifically in VS Code, but that solution would require better API support because currently there is no way to exactly correlate step names.

Fixes:

  • Add a globe icon (indicating an external site) which links to the specific step.
  • Change tooltip text from "View logs" to be more specific "View job logs" and "View step logs"

Demo:
viewlogsdemo

Additional info:
Talked to @andrewakim about this solution here: https://github.slack.com/archives/C03QVCCH1FZ/p1683051030748249
image

Co-authored by @lrotschy

@KetchupOnMyKetchup KetchupOnMyKetchup marked this pull request as ready for review May 2, 2023 18:47
@KetchupOnMyKetchup KetchupOnMyKetchup requested a review from a team as a code owner May 2, 2023 18:47
Comment thread src/commands/openWorkflowStepLogs.ts
Comment thread src/commands/openWorkflowStepLogs.ts
Comment thread src/commands/openWorkflowStepLogs.ts
Comment thread package.json
Comment thread package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] ability to open output of individual steps

3 participants