Improve Windows Dev Experience: fix npm commands (cross-env package), fix Source Control Repos, and document all#200
Merged
KetchupOnMyKetchup merged 18 commits intomainfrom May 23, 2023
Conversation
added 2 commits
May 22, 2023 12:15
felipesu19
previously approved these changes
May 22, 2023
elbrenn
reviewed
May 22, 2023
jtamsut
reviewed
May 22, 2023
jtamsut
reviewed
May 22, 2023
jtamsut
previously approved these changes
May 22, 2023
Contributor
jtamsut
left a comment
There was a problem hiding this comment.
Left a few non-blocking questions/comments
felipesu19
previously approved these changes
May 22, 2023
cschleiden
previously approved these changes
May 23, 2023
Co-authored-by: Christopher Schleiden <cschleiden@github.com>
Co-authored-by: Christopher Schleiden <cschleiden@github.com>
Co-authored-by: Christopher Schleiden <cschleiden@github.com>
Co-authored-by: Christopher Schleiden <cschleiden@github.com>
…hub/vscode-github-actions into ketchup/windowsDevExperience
felipesu19
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #89
--
Fix so that
npmcommands to work in Windows:cross-envpackage to vscode main projectPublic Archive, it is still being actively maintained "NOTICE: cross-env still works well, but is in maintenance mode. No new features will be added, only serious and common-case bugs will be fixed, and it will only be kept up-to-date with Node.js over time."package.json:format,format-check, andtestUpdates to Contributing.md doc
cross-envpackagenpmcommandsFixed Source Control Repositories (before it only showed vscode-github-actions and not language services), figured out from this issue:

Screenshots from Windows BEFORE changes (broken state):
Screenshots from Windows to show that it works still after changes:
Screenshots from Mac to show that it works still after changes: