Conversation
felipesu19
approved these changes
May 22, 2023
cschleiden
reviewed
May 23, 2023
Member
cschleiden
left a comment
cschleiden
left a comment
There was a problem hiding this comment.
couple comments where we could be a bit clearer
|
|
||
|  | ||
|
|
||
| By making the extension LSP compliant we have set the extension up to integrate with other text editors in the future. |
Member
There was a problem hiding this comment.
The extension will not integrate with other editors, but the separate language server implementation will allow us to integrate into other editors.
| - The [language service](https://github.com/actions/languageservices/tree/main/languageservice) library uses the workflow parser and expression engine (described below) to implement the core functionality of the extension | ||
| - it calls into the language server for any data that requires an API call | ||
| - the [workflow-parser](https://github.com/actions/languageservices/tree/main/workflow-parser) library parses GitHub Actions workflows into an intermediate representation and validates that the workflow file is syntactically valid | ||
| - the workflow parser uses a [JSON schema](https://github.com/actions/languageservices/blob/main/workflow-parser/src/workflow-v1.0.json) to parse the workflow file |
Member
There was a problem hiding this comment.
this might be a bit misleading, it's a custom schema definition not a json schema as in https://json-schema.org/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This document is targeted at those interested in contributing to the VS Code extension. Its includes a description of the technologies used and the overall components of the system.