Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@ All notable version changes will be recorded in this file.

***

### [v3.10.4] revision

**Fix**:
- `Task type: 'eide.msys'`: The `env` property does not work.

**Change**:
- `Task type: 'eide.msys'`: Use `label` property for task title, not `name`

***

### [v3.10.3] revision

**New**:
Expand Down
10 changes: 7 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"homepage": "https://em-ide.com",
"license": "MIT",
"description": "A mcu development environment for 8051/AVR/STM8/Cortex-M/RISC-V",
"version": "3.10.3",
"version": "3.10.4",
"preview": false,
"engines": {
"vscode": "^1.63.0"
Expand Down Expand Up @@ -1569,14 +1569,18 @@
{
"type": "eide.msys",
"required": [
"name",
"label",
"command"
],
"properties": {
"name": {
"label": {
"type": "string",
"description": "Task Name. A human-readable name for this task"
},
"name": {
"type": "string",
"description": "**Deprecated !!!** Task Name. A human-readable name for this task"
},
"command": {
"type": "string",
"description": "Command. A shell command will be executed."
Expand Down
2 changes: 1 addition & 1 deletion res/data/.clang-format
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ SortIncludes: false

AlignConsecutiveMacros: AcrossEmptyLines

#AlignConsecutiveAssignments: AcrossEmptyLines
AlignConsecutiveAssignments: Consecutive
2 changes: 1 addition & 1 deletion res/html/builder_options/js/app.js

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions src/EIDEProjectExplorer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4176,6 +4176,10 @@ export class ProjectExplorer implements CustomConfigurationProvider {
throw new Error(`Not found any reference for this source file !, [path]: '${srcPath}'`);
}

if (!File.IsFile(objPath)) {
throw new Error(`Object file is not existed !, [path]: '${objPath}'`);
}

// prepare command
let exeFile: File;
let cmds: string[];
Expand Down
8 changes: 5 additions & 3 deletions src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1164,7 +1164,9 @@ function RegisterGlobalEvent() {

interface EideShellTaskDef extends vscode.TaskDefinition {

name: string;
label: string;

name?: string;

command: string;

Expand Down Expand Up @@ -1192,14 +1194,14 @@ class EideTaskProvider implements vscode.TaskProvider {
const definition: EideShellTaskDef = <any>task_.definition;

const task = new vscode.Task(definition, vscode.TaskScope.Workspace,
definition.name, EideTaskProvider.TASK_TYPE_MSYS, definition.problemMatchers);
definition.name || definition.label, EideTaskProvider.TASK_TYPE_MSYS, definition.problemMatchers);

const shellcommand = definition.command;
task.execution = new vscode.ShellExecution(shellcommand, {
executable: platform.osType() == 'win32' ? `${process.env['EIDE_MSYS']}/bash.exe` : '/bin/bash',
shellArgs: ['-c'],
cwd: definition?.options?.cwd || workspaceManager.getCurrentFolder()?.path,
env: utility.mergeEnv(process.env, {})
env: utility.mergeEnv(process.env, definition.env || {})
});

task.group = definition.group;
Expand Down