Skip to content

v3.10.10 revision #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github0null merged 2 commits into from
Jan 20, 2023
Merged

v3.10.10 revision #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f156136
move usr-data.yaml file location
github0null Jan 20, 2023
d24a093
[other] show feedback/rating promt message
github0null Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/ResManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ export class ResManager extends events.EventEmitter {

getAppUsrData(): { [key: string]: any } | undefined {

const dataFile = File.fromArray([this.GetAppDataDir().path, 'data.yaml']);
const dataFile = File.fromArray([this.getEideHomeFolder().path, 'usr-data.yaml']);

if (dataFile.IsFile()) {
try {
Expand All @@ -246,8 +246,9 @@ export class ResManager extends events.EventEmitter {

data[key] = val;

File.fromArray([this.GetAppDataDir().path, 'data.yaml'])
.Write(yaml.stringify(data));
this.getEideHomeFolder().CreateDir(false);

File.fromArray([this.getEideHomeFolder().path, 'usr-data.yaml']).Write(yaml.stringify(data));
}

//=====================
Expand Down
10 changes: 10 additions & 0 deletions src/StringTable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,8 +592,18 @@ export const view_str$prompt$project_is_opened_by_another = [
`Can't lock project: '{path}', maybe this project has been opened by another EIDE instance !`
][langIndex];

export const view_str$prompt$feedback = [
`已经过去了一段时间，Embedded IDE 这款插件有帮到你吗？您可以在插件商店给予一个评分以帮助我们了解您的感受！`,
`A few days passed, has this plugin(Embedded IDE) helped you ? You can help us know how you feel by giving us a rating in the plugin store !`
][langIndex];

//---------------Select string------------------

export const rating_text = [
'打分',
'Rating'
][langIndex];

export const later_text = [
'稍后',
'Later on'
Expand Down
19 changes: 18 additions & 1 deletion src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ import { ResInstaller } from './ResInstaller';
import {
ERROR, WARNING, INFORMATION,
view_str$operation$serialport, view_str$operation$baudrate, view_str$operation$serialport_name,
txt_install_now, txt_yes
txt_install_now, txt_yes, view_str$prompt$feedback, rating_text, later_text
} from './StringTable';
import { LogDumper } from './LogDumper';
import { StatusBarManager } from './StatusBarManager';
Expand Down Expand Up @@ -294,6 +294,23 @@ function postLaunchHook(extensionCtx: vscode.ExtensionContext) {
}
}

// not first launch
else {

// A few days ago, show feedback message
const some_days = 7 * (24 * 3600 * 1000);
if (!appUsrData['Feedbacked'] &&
Date.now() - appUsrData['InstallTime'] > some_days) {
resManager.setAppUsrData('Feedbacked', true);
const msg = view_str$prompt$feedback;
vscode.window.showInformationMessage(msg, rating_text).then((ans) => {
if (ans == rating_text) {
utility.openUrl(`https://marketplace.visualstudio.com/items?itemName=CL.eide&ssr=false#review-details`);
}
});
}
}

// refresh external tools now
ResInstaller.instance().refreshExternalToolsIndex().catch(err => {
GlobalEvent.emit('globalLog', ExceptionToMessage(err, 'Warning'));
Expand Down