Skip to content

fix & optimize eide icon#243

Closed
Crystal-RainSlide wants to merge 18 commits intogithub0null:masterfrom
Crystal-RainSlide:eide-icon-fix
Closed

fix & optimize eide icon#243
Crystal-RainSlide wants to merge 18 commits intogithub0null:masterfrom
Crystal-RainSlide:eide-icon-fix

Conversation

@Crystal-RainSlide
Copy link
Copy Markdown

  • set <circle>'s cx from 80.285 to 80;
  • merge paths with same color (#878787);
  • remove unnessary rect / path;
  • icon.png is re-exported from Inkscape, then changed color mode to
    8-bit gray+alpha & compressed losslessly with ect -9 -strip.

Note that, since the original icon is using a 1.5px width stroke,
every edge is 0.75px wider than their real size.
The inner white rect is also affected and I'm using a 1.5px position drift
to mimic the original visual.

github0null and others added 17 commits April 17, 2023 14:55
- Implement MIPS (MTI) toolchain support for *nix and MinGW64 platforms as the
  MTI_GCC (MIPS MTI GCC Compiler) project type.
- Default to a baseline set of MIPS compiler flags.
- Add barebones GCC Model data in /res/data/models/*/mips.gcc.model.json.

Co-authored-by: Yu Shen <yu.shen@oss.cipunited.com>
Signed-off-by: Mingcong Bai <jeffbai@oss.cipunited.com>
Now it compiles a simple C hello-world program successfully with an empty template. like:

int main() {
	printf("hello");
	return 0;
}
@github0null
Copy link
Copy Markdown
Owner

Were there any potential problems with the previous images ?

What did these changes improve ?

I don't know much about this aspect of image processing.

@Crystal-RainSlide
Copy link
Copy Markdown
Author

Crystal-RainSlide commented May 7, 2023

Just some perfection and correction, let me explain my changes to icon.svg:

  • -<path fill="none" d="M0 0h160v160H0z"/>

    Invisible <path> which did nothing at all, removed.

  • -<circle cy="80" cx="80.285" fill="#fff" r="80"/>
    +<circle cx="80" cy="80" r="80" fill="#fff"/>

    Original image's white circle is not perfectly centered, but off to right by 0.285px, fixed.

    One may confirm this tiny position drifting error by compare the mirrored and non-mirrored version of the original icon.

    This change corrected visual, which means it affected the PNG, so I re-exported & compressed icon.png.

  • -<path stroke-width="1.5" stroke="#878787" fill="#878787" d="M47 47h66v66H47z"/><path stroke-width="1.5" stroke="#fff" fill="#fff" d="M68 68h24v24H68z"/><path stroke-width="1.5" stroke="#878787" fill="#878787" d="M53 113h12v15H53zM74 113h12v15H74zM95 113h12v15H95zM113 53h15v12h-15zM113 95h15v12h-15zM113 74h15v12h-15zM53 32h12v15H53zM74 32h12v15H74zM95 32h12v15H95zM32 53h15v12H32zM32 74h15v12H32zM32 95h15v12H32z"/>
    +<path fill="#878787" stroke="#878787" stroke-width="1.5" d="M47 47h6V32h12v15h9V32h12v15h9V32h12v15h6v6h15v12h-15v9h15v12h-15v9h15v12h-15v6h-6v15H95v-15h-9v15H74v-15h-9v15H53v-15h-6v-6H32V95h15v-9H32V74h15v-9H32V53h15zm19.5 19.5v27h27v-27z"/>

    The optimization, merged 3 paths into 1 path, which should be the shortest currect solution for the dark inner shape on this icon.

    The white inner rect, <path stroke-width="1.5" stroke="#fff" fill="#fff" d="M68 68h24v24H68z"/>, is replaced with a real square hole (m19.5 19.5v27h27v-27z) in the new path, and thus no longer needed and removed.

@github0null
Copy link
Copy Markdown
Owner

ok

@github0null github0null closed this May 8, 2023
@github0null github0null reopened this May 8, 2023
@github0null
Copy link
Copy Markdown
Owner

github0null commented May 8, 2023

And you need to commit to dev branch

The master is readonly

set <circle>'s cx from 80.285 to 80;
merge paths with same color (#878787);
remove unnessary rect/path.
@Crystal-RainSlide
Copy link
Copy Markdown
Author

New PR which commits to dev branch: #244

@Crystal-RainSlide Crystal-RainSlide deleted the eide-icon-fix branch May 16, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants