Merged
Conversation
read a json mirror config file back in it loads the obstruction value 100X too small (for annular mirrors).
atsju
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug I had missed in mirror configuration. When reading a json config file back in, if you have
an annulus mirror, it would load the diameter of the inner annulus value 100X too small.
So if the diameter of the mirror was 200mm and the percent of the annulus was 50% it would show 1mm diameter annulus instead of 100mm.
The confusing I think comes from the name of the member variable "m_annularObsPercent" which is really a ratio from 0 to 1 and not a value from 1 to 100.