Conversation
|
This PR should probably be integrated in next release. Hopefully I can test that the minidump contains good information before the release is published. |
|
I plan to make sure this builds fine the way Dale and I build. today or tomorrow. |
|
UPDATE: I tried to analyse my minidump with windbg tool. It gives some information about the exception but because we build with mingw and not MSVC, the .debug file cannot be used by windbg to fully unveil it's potential. However the minidump contains a stacktrace that we could possibly analyse with addr2line (for the "wave front inspector" crash there was no meaningful info so I'm really not sure) I see 2 path of action:
I would lean for the first. What do you think ? |
|
I don't have an opinion so I'll trust you to choose. |
|
@atsju did you see my comment above? |
I did see. I did not decide. Let's keep it and see if it brings something on futur crashes |
|
Maybe I wasn't clear in the comments above. This won't compile for me because you added something to the "normal" .pro file but forgot to add it to the dale .pro file. That's why I haven't approved this PR yet. |
I get it now. I will fix it. |
| LIBS += -L..\build_openCV\install\x64\mingw\bin -llibopencv_highgui460 | ||
| LIBS += -L..\build_openCV\install\x64\mingw\bin -llibopencv_imgcodecs460 | ||
| LIBS += -L..\build_openCV\install\x64\mingw\bin -llibopencv_imgproc460 | ||
| LIBS += -ldbghelp # for SetUnhandledExceptionFilter |
There was a problem hiding this comment.
Please add this line to DFTFringe_Dale.pro
After doing that this PR builds just fine in qtcreator.
|
Okay so I made the same mistake dale did. I did an inline comment among the code changes and wondered why Julien ignored it. Anyway he took care of it so this is ready to merge. |
Close #203
This adds a minidump to all crashes.
Crashes from unhandled exception catched with
std::set_terminatewill have stacktrace and minidump.Harsher crashes catched with
SetUnhandledExceptionFilterwith only show minidump as spdlog doesn't work during these crashes. To reproduce : open DFTFringe, load no wave front and click on tools -> wave front inspectorSetUnhandledExceptionFilterto catch crashes that are not handled todaytry exporting registry keys in case of crashThis PR should help us debug unexplained crashes.