Minor Changes necessary for QT6 that are compatible with QT5 #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsju
commented
Jul 27, 2025
Merged
gr5
reviewed
Jul 27, 2025
gr5
reviewed
Jul 28, 2025
gr5
approved these changes
Jul 28, 2025
Collaborator
|
oops! Please don't merge yet. The only thing remaining that I'm worried about is the "even number" issue. |
atsju
commented
Jul 28, 2025
Collaborator
|
I think this is fine to merge now. |
Collaborator
Author
|
@githubdoe Do you have any remark on this one ? In #206 (zernike) you clearly expressed you want to think about the changes and I'm fine with that. |
githubdoe
approved these changes
Jul 30, 2025
Owner
|
Yes I think I want to review them. However I don't have a lot of time to do it as I would like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #191 QT5 support is slowly falling appart.
However I don't want to break development flow for Dale. So here is a set of changes that are compatible with QT5.
I want to integrate them now, so the futur move to QT6 is easier and I can maintain the QT6 branch on my side until we decide to move.
@gr5 there is one change related to OpenCV that I only tested with CV 4.6.0. However Dale is building with CV 3.4.12. Could you test if this compiles as I suppose you already have this version available ?