bump version, change --no-cache#27
Merged
Rucknar merged 1 commit intogithubexporter:masterfrom Nov 15, 2017
utf18:patch-1
Merged
bump version, change --no-cache#27Rucknar merged 1 commit intogithubexporter:masterfrom utf18:patch-1
Rucknar merged 1 commit intogithubexporter:masterfrom
utf18:patch-1
Conversation
bump version of golang to 1.9 and change builder image to --no-cache. IMHO no need to keep the package cache. so there is then also no need to clean the /var/cache/apk/* folder which i would have added when you want to keep the --update. All the best, Benjamin
Rucknar
approved these changes
Nov 15, 2017
Contributor
Rucknar
left a comment
Rucknar
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump version of golang to 1.9 and change builder image to --no-cache.
IMHO no need to keep the package cache. so there is then also no need to clean the
/var/cache/apk/* folder which i would have added when you want to keep the --update.
All the best,
Benjamin