feat: added more fields to the metrics#31
Merged
Rucknar merged 4 commits intogithubexporter:masterfrom Nov 13, 2018
caarlos0:more
Merged
feat: added more fields to the metrics#31Rucknar merged 4 commits intogithubexporter:masterfrom caarlos0:more
Rucknar merged 4 commits intogithubexporter:masterfrom
caarlos0:more
Conversation
- license - language - if it is a fork - if it is archived
Contributor
Author
|
cc/ @Rucknar |
Contributor
|
Thanks for the PR! Code looks good to me, could you also update the docs? I've listed the metrics people can expect in the |
Contributor
Author
|
hi @Rucknar I wasn't sure about what was the best way of doing that, so I basically re-generated that output using "live" data. Let me know what you think! Cheers! |
tianon
reviewed
Jul 22, 2018
| prometheus.BuildFQName("github", "repo", "watchers"), | ||
| "Total number of watchers/subscribers for given repository", | ||
| []string{"repo", "user", "private"}, nil, | ||
| []string{"repo", "user", "private", "fork", "arhived", "license", "language"}, nil, |
There was a problem hiding this comment.
Shouldn't arhived in all these rather be archived? (minor typo)
Contributor
Author
There was a problem hiding this comment.
good catch, fixed, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
namely:
PS: maybe it doesn't even make sense to report metrics on archived repositories, as they can't be changed... if you agree, I can fix that in this PR as well :)
Thanks!