Make config externally settable without environment variables.#71
Merged
Rucknar merged 1 commit intogithubexporter:masterfrom Jul 23, 2021
Merged
Make config externally settable without environment variables.#71Rucknar merged 1 commit intogithubexporter:masterfrom
Rucknar merged 1 commit intogithubexporter:masterfrom
Conversation
Rucknar
approved these changes
Jul 23, 2021
Contributor
Rucknar
left a comment
Rucknar
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the config struct. Previously, the config struct exported external state such as the list of repositories, organisations, and users, as well as values used for the API token.
However, the config struct did not export the "magic funcs" which are applied to concatenate all of the various target URLs, or which allow one to use an APIToken string, or a file containing an APIToken string.
This PR makes it possible to properly set and pass along those values from an external consumer, like the Grafana Agent.