docs: fix stale engine template docs, add TODO for test engine hardcode#295
Merged
jamesadevine merged 1 commit intomainfrom Apr 22, 2026
Merged
docs: fix stale engine template docs, add TODO for test engine hardcode#295jamesadevine merged 1 commit intomainfrom
jamesadevine merged 1 commit intomainfrom
Conversation
…hardcode
- Replace obsolete {{ copilot_ado_env }} AGENTS.md section with correct
{{ engine_env }} docs (engine-specific env vars: GITHUB_TOKEN, OTEL)
- Add TODO to CompileContext::for_test() flagging hardcoded Engine::Copilot
as tech debt for when multiple engines are supported
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🔍 Rust PR ReviewSummary: Looks good — clean docs fix with accurate content, and a well-placed TODO. Findings✅ What Looks Good
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #286 — fixes two items missed in the merge:
Changes
AGENTS.md: Replace stale
{{ copilot_ado_env }}section with correct{{ engine_env }}docs. The template marker was renamed but the docs still described the old semantics (ADO token passthrough). The actual{{ engine_env }}generates engine-specific env vars (GITHUB_TOKEN, OTEL config) viaEngine::env().CompileContext::for_test(): Add TODO comment flagging that
Engine::Copilotis hardcoded. Currently correct (only engine), but will need to resolve fromfront_matter.enginewhen additional engines are added.Testing
All 930 tests pass.