Skip to content

feat: wire engine.version, engine.command, and engine.agent through to pipeline output#297

Closed
Copilot wants to merge 4 commits intomainfrom
copilot/feat-wire-engine-fields-to-output
Closed

feat: wire engine.version, engine.command, and engine.agent through to pipeline output#297
Copilot wants to merge 4 commits intomainfrom
copilot/feat-wire-engine-fields-to-output

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 22, 2026

engine.version, engine.command, and engine.agent were parsed into EngineOptions but silently ignored with compile-time warnings. This wires all three through to the generated pipeline YAML.

engine.agent

  • Adds --agent <value> to Copilot CLI args in copilot_args()
  • Validates identifier: alphanumeric + hyphens only (no path separators)

engine.version

  • Overrides COPILOT_CLI_VERSION in the NuGet install step
  • "latest" omits the -Version flag entirely
  • Validated against shell-safe characters

engine.command

  • Skips all NuGet install steps (auth, install, binary copy, version output)
  • Uses custom path in AWF invocation instead of /tmp/awf-tools/copilot
  • Validated against shell metacharacters

Template changes

  • Replaced hardcoded install blocks in base.yml and 1es-base.yml with {{ engine_install_steps }} marker
  • Replaced hardcoded /tmp/awf-tools/copilot with {{ copilot_command }} marker
  • Install steps are now dynamically generated by Engine::install_steps()
# Pins a specific CLI version
engine:
  id: copilot
  version: "0.0.422"

# Brings your own binary, skips install entirely
engine:
  id: copilot
  command: /usr/local/bin/my-copilot

# References a custom Copilot agent file
engine:
  id: copilot
  agent: technical-doc-writer

15 new unit tests covering all three features and their validation. api-target, args, and env remain unwired with warnings.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dev.azure.com
    • Triggering command: /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-c05a54f0ee13c0b7 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-c05a54f0ee13c0b7 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw_derive-75d10f00d9cc0c6f/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/compiler_tests-a8a48394b293b055.17unxb5laoekqixkf4qnr6sbw.0ajje0v.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw_derive-75d10f00d9cc0c6f/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/compiler_tests-a8a48394b293b055.18g4t9rqadmplukldxxwfdghh.0ajje0v.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw_derive-75d10f00d9cc0c6f/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/compiler_tests-a8a48394b293b055.1if8uc8ofutahxkln01oe5axr.0ajje0v.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw_derive-75d10f00d9cc0c6f/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/compiler_tests-a8a48394b293b055.1qlvx6rnt00u2kwrwh6tk8tw3.0ajje0v.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw_derive-75d10f00d9cc0c6f/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/compiler_tests-a8a48394b293b055.21b9o5zsud4g3k1pq9q72uu2y.0ajje0v.rcgu.o 0.03l0815d29lj002ae3mmxfl3m.0cea9yi.rcgu.o 0.0tn8ejcnvgjygdyylhtak9lpf.0cea9yi.rcgu.o 0.0xx92o0xvmao3s3mmpaude4gm.0cea9yi.rcgu.o 0.11wu39pl8x5unsfa0pm0sx7i8.0cea9yi.rcgu.o 0.15ekd7s10qhmgvd15js1u58j5.0cea9yi.rcgu.o 0.20695tlwm01eu06f6nytfaj15.0cea9yi.rcgu.o 0.25dmyxexlbrf6s096aq9lq99g.0cea9yi.rcgu.o 0.26zkdc197kx7li1nwob9t5xj9.0cea9yi.rcgu.o 0.2cvf4nkhwgdzrg6bb0j1g45xz.0cea9yi.rcgu.o 0.2figln0c2pfqzi2e08i006o8u.0cea9yi.rcgu.o 0.2fla2kplyo8fcs0of160c962a.0cea9yi.rcgu.o 0.2ikaohql56ne0w9lfnxyhwv2k.0cea9yi.rcgu.o 0.2oqlsydd3dffl94jckwj4qblh.0cea9yi.rcgu.o 0.2pfydlp0bjr74wlj1t3r6ms18.0cea9yi.rcgu.o (dns block)
    • Triggering command: /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-c05a54f0ee13c0b7 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-c05a54f0ee13c0b7 tcp -m conntrack --ctstate INVALID,NEW -j DROP target/debug/depgit target/debug/depremote target/debug/depget-url target/debug/deporigin targ�� target/debug/deps/rustc0RZW5e/symbols.o target/debug/deps/cli_tests-236509acf1c53b8d.00s-plugin-opt=-fresolution=/tmp/ccmBup07.res target/debug/deps/cli_tests-236509acf1c53b8d.050--build-id target/debug/depiptables target/debug/dep-w target/debug/dep-t target/debug/depsecurity (dns block)
    • Triggering command: /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-c05a54f0ee13c0b7 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-c05a54f0ee13c0b7 target/debug/depclippy target/debug/dep--all-targets bin/rustc targ�� target/debug/dep-C target/debug/depdebuginfo=2 f/option-ext-0.2.0/src/lib.rs 75d10f00d9cc0c6fgit 75d10f00d9cc0c6fremote 75d10f00d9cc0c6fget-url target/debug/adoorigin remo�� d-wildcard-11763/network-mid-wildcard.md k/ado-aw/ado-aw/target/debug/deps/ado_aw-27c82a3c1bf695e8.01lkw2enzrk7n07labib8uokr.1joi4a1.rcgu-m64 known-linux-gnu/bin/rustc k/ado-aw/ado-aw/git k/ado-aw/ado-aw/remote k/ado-aw/ado-aw/get-url known-linux-gnu/origin (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI and others added 3 commits April 22, 2026 07:59
…o pipeline output

Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/027e899d-0a4c-4784-81ca-c6b0142bfb08

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
…engine.agent fields

Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/027e899d-0a4c-4784-81ca-c6b0142bfb08

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
…nd redundant validation

Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/027e899d-0a4c-4784-81ca-c6b0142bfb08

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot AI changed the title [WIP] Wire engine.version, engine.command, and engine.agent to pipeline output feat: wire engine.version, engine.command, and engine.agent through to pipeline output Apr 22, 2026
Copilot AI requested a review from jamesadevine April 22, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: wire engine.version, engine.command, and engine.agent through to pipeline output

2 participants