fix(compile): pin LF eol on managed gitattributes entries#340
Merged
jamesadevine merged 1 commit intomainfrom Apr 28, 2026
Merged
fix(compile): pin LF eol on managed gitattributes entries#340jamesadevine merged 1 commit intomainfrom
jamesadevine merged 1 commit intomainfrom
Conversation
Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/5acd63b7-baaf-491a-932a-acee2d27b97f Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jamesadevine
April 28, 2026 14:11
View session
jamesadevine
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows (default
core.autocrlf=true), every recompile producedwarning: in the working copy of '<pipeline>.yml', LF will be replaced by CRLF the next time Git touches it, because the compiler writes LF but Git assumed CRLF was canonical for these files.Summary
src/compile/gitattributes.rs: extend the per-fileATTRIBUTESconstant fromlinguist-generated=true merge=ourstolinguist-generated=true merge=ours text eol=lf, declaring LF as the canonical EOL for compiled pipelines.ado-aw checkintegrity holds..gitattributeschange: the managed block already enumerates every compiled pipeline.Resulting line per pipeline:
Test plan
writes_new_gitattributes_when_missing,preserves_user_managed_lines,replaces_existing_managed_block,quotes_paths_containing_spaces).entries_pin_lf_eolregression test so thetext eol=lfattribute can't be silently dropped.cargo testandcargo clippy --all-targets --all-featuresboth clean.