test(runtimes): add validate() unit tests and feed-url integration tests for all runtime extensions#509
Merged
Conversation
…s for all runtime extensions Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/015b4c34-17aa-4a0c-984b-f25f56b6e8d4 Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix test gaps in runtime extension validate() paths
test(runtimes): add validate() unit tests and feed-url integration tests for all runtime extensions
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All four runtime extension
validate()implementations had zero unit tests — error branches for bash-disabled warnings, mutual-exclusivitybail!s, invalid feed URLs, and version injection were completely uncovered. Additionally,PipAuthenticate/npmAuthenticatecode paths and their injected env vars were never exercised end-to-end.Changes
Unit tests —
src/compile/extensions/tests.rs(+10 tests)Python
validate()branches:test_python_validate_bash_disabled_warning/test_python_validate_bash_not_disabled_no_warningtest_python_invalid_feed_url_rejected— scheme-less URL rejectedtest_python_validate_version_injection_rejected—$(SECRET)in version field rejectedNode
validate()branches:test_node_validate_bash_disabled_warningtest_node_invalid_feed_url_rejectedtest_node_validate_version_injection_rejectedDotnet
validate()branches:test_dotnet_validate_bash_disabled_warningtest_dotnet_validate_version_injection_rejectedtest_dotnet_validate_config_injection_rejectedIntegration tests —
tests/compiler_tests.rs(+2 tests)test_python_runtime_with_feed_url_compiled_output— asserts compiled YAML containsPipAuthenticate@1,PIP_INDEX_URL, andUV_DEFAULT_INDEXtest_node_runtime_with_feed_url_compiled_output— asserts compiled YAML containsnpmAuthenticate@0andNPM_CONFIG_REGISTRYThese mirror the existing
test_dotnet_runtime_with_feed_url_compiled_outputpattern.Test plan
cargo test— all 1,461 tests pass (15 new).Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
spsprodeus21.vssps.visualstudio.com/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.0gsn8ev1cnkk8096ejd9eaqnc.1ch99uz.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.0hnyc0p3974v12h5g8kkwz19v.1ch99uz.rcgu.o 64-REDACTED-linux-gnu/bin/rust-lld /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.12nfqzyx5t92gdliu6u9j2t23.1ch99uz.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.1bcwhu0k0xfbj80ouktlgq7gg.1ch99uz.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.1bhjf3uobqgssktgi0e14aqnn.1ch99uz.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.1hqz8k3c94266bfgrfbuybt2z.1ch99uz.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.1huk6ich8t6qwyn0rf9m9q3l0.1ch99uz.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.1t�� /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.270d89qd8zd7pddtw479jvwb6.1ch99uz.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.2i0rx46105zwgayhinkt9jur2.1ch99uz.rcgu.o res-�� res-0d1f7d618793--error-format=json res-0d1f7d618793--json=diagnostic-rendered-ansi,artifacts,future-incompat lib/rustlib/x86_64-REDACTED-linux-gnu/bin/gcc-ld/ld.lld res-0d1f7d618793cc eta.o res-0d1f7d618793/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/rustc8Xya6Q/symbols.o lib/rustlib/x86_/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.006607excnbrprqp637f7y53i.1ch99uz.rcgu.o(dns block)/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 dcz8k01ygw1jgx02lqr.1twv162.rcgu.o hs5eqhc4fqriclfc1dx.1twv162.rcgu.o pr9xlw0hyhr705nvbdz.1twv162.rcgu.o q7as�� ac0q57k0g0ay8in873l.1twv162.rcgu.o 7qvtieefzhx3h324csh.1twv162.rcgu.o db084d5b4f75.10m/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/compiler_tests-3b7233ec49ad28c--noprofile db084d5b4f75.121bash db084d5b4f75.13b--norc db084d5b4f75.1ek--noprofile db084d5b4f75.1qf/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/compiler_tests-3b7233ec49ad28cb.1i2kcjxs7gl6ur6hcoftevybq.1dvjnmp.rcgu.o db08�� mbols.o 127ec4700.026ly9km5g0nk5x41u88thfo4.1twv162.rcgu.o 127ec4700.0440lt1wf3anxu1eriweo0k7q.1twv162.rcgu.o 127ec4700.046vrebash 127ec4700.05puzw--norc 127ec4700.06xt1j--noprofile 127ec4700.0a79c27ywqx6da6h6q5fcwyko.1twv162.rcgu.o(dns block)/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 ,SC1091 eck shellcheck --sh�� --format=json ,SC1091 heck --format=json ,SC1091 ndor/bin/shellchget-url shellcheck --sh�� --format=json ,SC1091 de/node/bin/git --format=json ,SC1091 de/node/bin/shelget-url shellcheck(dns block)spsprodweu4.vssps.visualstudio.com/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.0gsn8ev1cnkk8096ejd9eaqnc.1ch99uz.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.0hnyc0p3974v12h5g8kkwz19v.1ch99uz.rcgu.o 64-REDACTED-linux-gnu/bin/rust-lld /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.12nfqzyx5t92gdliu6u9j2t23.1ch99uz.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.1bcwhu0k0xfbj80ouktlgq7gg.1ch99uz.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.1bhjf3uobqgssktgi0e14aqnn.1ch99uz.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.1hqz8k3c94266bfgrfbuybt2z.1ch99uz.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.1huk6ich8t6qwyn0rf9m9q3l0.1ch99uz.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.1t�� /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.270d89qd8zd7pddtw479jvwb6.1ch99uz.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.2i0rx46105zwgayhinkt9jur2.1ch99uz.rcgu.o res-�� res-0d1f7d618793--error-format=json res-0d1f7d618793--json=diagnostic-rendered-ansi,artifacts,future-incompat lib/rustlib/x86_64-REDACTED-linux-gnu/bin/gcc-ld/ld.lld res-0d1f7d618793cc eta.o res-0d1f7d618793/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/rustc8Xya6Q/symbols.o lib/rustlib/x86_/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668bf.006607excnbrprqp637f7y53i.1ch99uz.rcgu.o(dns block)/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 dcz8k01ygw1jgx02lqr.1twv162.rcgu.o hs5eqhc4fqriclfc1dx.1twv162.rcgu.o pr9xlw0hyhr705nvbdz.1twv162.rcgu.o q7as�� ac0q57k0g0ay8in873l.1twv162.rcgu.o 7qvtieefzhx3h324csh.1twv162.rcgu.o db084d5b4f75.10m/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/compiler_tests-3b7233ec49ad28c--noprofile db084d5b4f75.121bash db084d5b4f75.13b--norc db084d5b4f75.1ek--noprofile db084d5b4f75.1qf/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/compiler_tests-3b7233ec49ad28cb.1i2kcjxs7gl6ur6hcoftevybq.1dvjnmp.rcgu.o db08�� mbols.o 127ec4700.026ly9km5g0nk5x41u88thfo4.1twv162.rcgu.o 127ec4700.0440lt1wf3anxu1eriweo0k7q.1twv162.rcgu.o 127ec4700.046vrebash 127ec4700.05puzw--norc 127ec4700.06xt1j--noprofile 127ec4700.0a79c27ywqx6da6h6q5fcwyko.1twv162.rcgu.o(dns block)/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 ,SC1091 eck shellcheck --sh�� --format=json ,SC1091 heck --format=json ,SC1091 ndor/bin/shellchget-url shellcheck --sh�� --format=json ,SC1091 de/node/bin/git --format=json ,SC1091 de/node/bin/shelget-url shellcheck(dns block)If you need me to access, download, or install something from one of these locations, you can either: