test(bash-lint): cover GateContext::PullRequest via pr-filter-tier1 fixture#515
Merged
jamesadevine merged 2 commits intoMay 13, 2026
Merged
Conversation
…ixture
Add `pr-filter-tier1-agent.md` to the FIXTURES list so the bash-lint
integration test compiles and shellchecks the gate step produced by
`GateContext::PullRequest` in `src/compile/filter_ir.rs`.
Add "Evaluate PR filters" to REQUIRED_STEP_DISPLAY_NAMES to ensure the
generator is always exercised; the test will now fail loudly if the
pr-filter fixtures are removed or the display name changes.
Previously only the pipeline-completion variant ("Evaluate pipeline
filters") was tracked; the PR-trigger variant shared the same generator
but had no coverage guarantee.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Contributor
Resolved and pushed in commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the lint found
The baseline lint was green (
exit 0), so this is a proactive coverage improvement (Step 4c).Audit revealed that
src/compile/filter_ir.rshas twoGateContextvariants that each emit a- bash:step:GateContext::PipelineCompletion→"Evaluate pipeline filters"— already tracked inREQUIRED_STEP_DISPLAY_NAMESand exercised bypipeline-filter-agent.mdGateContext::PullRequest→"Evaluate PR filters"— not tracked, andpr-filter-tier1-agent.md/pr-filter-tier2-agent.mdwere absent from the lint'sFIXTURESlistBoth variants share the same codegen path in
filter_ir.rs, but without the PR fixture inFIXTURESthere was no guarantee the PR-gate bash body would ever reach shellcheck.How it was fixed
tests/bash_lint_tests.rs: added"pr-filter-tier1-agent.md"toFIXTURESso the compiler's PR-filter output is compiled and linted on every CI run.tests/bash_lint_tests.rs: added"Evaluate PR filters"toREQUIRED_STEP_DISPLAY_NAMES(with source comment pointing tofilter_ir.rs) so the test fails loudly if the fixture is removed or the display name changes.No production code was changed.
Verification
Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
dev.azure.comreleaseassets.githubusercontent.comSee Network Configuration for more information.