docs(site): update filter-ir page to reflect Node/TypeScript gate evaluator#634
Merged
jamesadevine merged 1 commit intoMay 19, 2026
Merged
Conversation
…luator Replace stale Python evaluator references with the current Node/TypeScript implementation. The gate evaluator was migrated from a Python heredoc (gate-eval.py / scripts.zip) to a bundled TypeScript program (gate.js / ado-script.zip). The site documentation did not track this change. Key corrections: - Codegen pass: 'Python evaluator' -> 'Node.js gate evaluator' - Generated step structure: Python heredoc -> 'node /.../gate/index.js' call - Evaluator section: renamed from 'Python Gate Evaluator (scripts/gate-eval.py)' to 'Bundled Gate Evaluator (scripts/ado-script/src/gate/)'; updated language (os.environ -> process.env, urllib -> azure-devops-node-api, datetime -> Date.now()) - Predicates table: FileGlobMatch description no longer mentions Python fnmatch - TriggerFiltersExtension: added Node install step; changed download artifact from scripts.zip/gate-eval.py to ado-script.zip/gate.js at correct path - Removed stale 'Tier 1 Inline Path' section (all filters now use Node evaluator) - Gate Step Injection: removed inline gate step reference - Scripts Distribution: updated to ado-script.zip / gate.js bundle URL - Adding New Filter Types: updated evaluator file from gate-eval.py to scripts/ado-script/src/gate/predicates.ts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jamesadevine
deleted the
docs/filter-ir-node-gate-evaluator-93834616e94589c1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
site/src/content/docs/reference/filter-ir.mdx— corrected all stale Python/scripts.zip references to match the current Node/TypeScript/ado-script.zip implementationAccuracy checks
src/compile/extensions/trigger_filters.rs: module docstring confirms "All filter types (simple and complex) are evaluated by the Node evaluator — there is no inline bash codegen path";GATE_EVAL_PATH = "/tmp/ado-aw-scripts/ado-script/dist/gate/index.js"; downloadsado-script.zipsrc/compile/filter_ir.rs: comment referencesscripts/ado-script/dist/gate/index.js;GateSpecdoc comment says "Node gate evaluator"src/compile/pr_filters.rs: comment "Gate step generation is now handled entirely by TriggerFiltersExtension"docs/filter-ir.md(source-of-truth repo docs): already updated to Node/TypeScript; site page was behindKey corrections:
scripts/ado-script/dist/gate/index.js)"python3 << 'GATE_EVAL_EOF') →node '/tmp/ado-aw-scripts/ado-script/dist/gate/index.js'Python Gate Evaluator (scripts/gate-eval.py)toBundled Gate Evaluator (scripts/ado-script/src/gate/); language updated (os.environ→process.env,urllib→azure-devops-node-api,datetime.now(timezone.utc)→Date.now())FileGlobMatch— removed stale "Pythonfnmatchglobs" descriptionscripts.zip/gate-eval.pytoado-script.zip/gate.jsat correct path/tmp/ado-aw-scripts/ado-script/dist/gate/index.jsscripts.ziptoado-script.zipscripts/gate-eval.py→scripts/ado-script/src/gate/predicates.tsValidation
cd site && npm ci && npm run build— 28 pages built, all internal links validCreated by the docs-writer workflow.