You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary: Auto-generated regeneration — looks good, no logic issues found.
Note: This PR was already merged. This review is for informational purposes.
Findings
✅ What Looks Good
Consistent version bumps across all 26 .lock.yml files: ado-aw 0.30.1→0.31.1, Copilot CLI 1.0.47→1.0.48, AWF 0.25.44→0.25.48, MCPG 0.3.7→0.3.12. No stragglers.
New runtime-import mechanism is correctly sequenced: {{#runtime-import ...}} marker is written to agent-prompt.md before import.js resolves it, which runs before the AWF agent stage.
Checksum verification for ado-script.zip is present (grep ... checksums.txt | sha256sum -c -), mitigating supply-chain tampering.
condition: succeeded() on NodeTool, ado-script download, and import resolution steps ensures a broken import chain fails loudly rather than silently passing an unresolved {{#runtime-import ...}} string to the agent.
All 26 aw_info.json blocks are valid JSON with the full required field set.
NodeTool + ado-script steps are Stage 1 only — correctly absent from the detection (Stage 2) and safe-outputs (Stage 3) jobs.
⚠️ Suggestions
tests/safe-outputs/*.lock.yml — ado-script download uses hardcoded version instead of ${COMPILER_VERSION}: The ado-aw binary download step correctly uses COMPILER_VERSION="0.31.1" as a variable, but the new ado-script download step hard-codes v0.31.1 in the URLs. Since these are generated files this is never wrong at generation time, but using the variable in the compiler template would be more consistent:
# template suggestion
curl -fsSL "(redacted)
Low priority.
model: gpt-5-mini appears in all aw_info.json metadata blocks (sourced from engine.model in the .md fixtures). Not a generated-YAML issue, but worth confirming this model identifier is valid in the runtime environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan