Fix Crane completion gating#103
Merged
Merged
Conversation
github-actions Bot
added a commit
that referenced
this pull request
Jun 3, 2026
…35: Register PR #103 tests in coverage manifest Changes: - Add 5 new tests from PR #103 (crane completion gating) to python_contract_coverage.yml - Fixes python_behavior_contracts gate failing (unknown tests not mapped as obsolete) - All 10/10 deletion-grade gates now pass, migration_score=1.0 Run: https://github.com/githubnext/apm/actions/runs/26899293692 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Refs #78. This makes Crane completion two-phase: reaching the migration target metric creates a completion candidate, but final completion requires the current pushed PR head checks to be terminal success. It also lets the scheduler recover issues that were already moved to
crane-completedwhen their PR-head gate is not actually green.Problem
Issue #78 could be marked
crane-completedeven though PR #102 still had a failing parity gate. Oncecrane-migrationwas removed, the issue stopped being discovered by scheduled Crane runs, so no follow-up work happened.Approach
target-metricas a candidate signal, not a final completion signal.Completion Candidate,Completion Gate, andCompletion Gate Status.successbefore swappingcrane-migrationforcrane-completed.crane-completedissues too, evaluate their current PR head checks, and re-select stale completed issues whose gate is missing, pending, or failing.Implementation
.github/workflows/crane.md.github/workflows/scripts/crane_scheduler.pycrane-completedissues, evaluates exact PR-head check runs, and treats failing completed-label issues as due work.tests/unit/test_crane_scheduler.pytests/unit/test_crane_workflow_prompt.pyTrade-offs
gh aw compilecould not be run locally becauseghis not installed in this environment. The source workflow body changed; the current lock file runtime-imports the workflow body, but CI should still run the official lock check.Validation
Blocked locally:
How to test
target-metric: 1.0and an existing Crane PR.crane-migration, does not keepcrane-completed, and records a pending/failing completion gate status.crane-completed.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com