ci: ensure migration benchmark runs#93
Merged
Merged
Conversation
0b08b5b to
8faa590
Compare
7 tasks
8faa590 to
dbabdff
Compare
Contributor
Migration Benchmark Results
Migration CLI BenchmarkMax allowed Go/Python median ratio:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
This fixes the migration benchmark workflow so the Python-vs-Go CLI benchmark actually runs in Actions, uploads benchmark evidence, and posts benchmark results back to the PR for each head commit. It also removes the top-level PR path filter so the workflow is created on every PR update; Crane migration branches then force the migration checks to run on every commit.
What changed
crane/*PR branches, even when a commit only touches orchestration or generated metadata.Validation
/opt/homebrew/bin/actionlint .github/workflows/migration-ci.ymlgit diff --check HEAD~1 HEADPYTHONPYCACHEPREFIX=/private/tmp/apm-pycache python3 -m py_compile scripts/ci/migration_cli_benchmark.pypython3 scripts/ci/migration_cli_benchmark.py --python-bin /usr/bin/true --go-bin /usr/bin/true --json-out /private/tmp/migration-cli-benchmark-smoke.json --markdown-out /private/tmp/migration-cli-benchmark-smoke.md --repeats 126557634231: Detect Migration Changes, Python-vs-Go Parity Gate, and Migration Benchmarks all passed.dbabdffd7801279bf4053a98026fa496f9505f9f.How to test
crane/*migration PR branch.